Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MISC changes...still learning #76

Merged
merged 9 commits into from
Sep 22, 2014
Merged

MISC changes...still learning #76

merged 9 commits into from
Sep 22, 2014

Conversation

gleckler1
Copy link
Contributor

PG still learning to use git

Created CMIP_RESULTS DIR

Updated generation of src/python/pcmdi/scripts/build_obs_meta_dictionary.py, which added to metadata to json files on obs

updated python used for pcmdi_metrics_driver.py and build_obs_meta_dictionary.py

@doutriaux1
Copy link
Contributor

@gleckler1 you removed sftlf I think that is going to break the test cases can you please run them and let me know?

Thanks,

C.

@doutriaux1
Copy link
Contributor

@doutriaux1
Copy link
Contributor

@gleckler1 you should also probably use your own branches so that you can keep developping while waiting for the merge to happen. Get the CMIP5 json files out first @durack1 will explain you the rest then.

@durack1
Copy link
Collaborator

durack1 commented Sep 18, 2014

The sftlf file is found in the test suite, so was never included in the obs dictionary.. It's located at ../PCMDI_METRICS/test/pcmdi/obs/fx/mo/sftlf/UKMETOFFICE-HadISST-v1-1/ac so I'd be surprised if Pete's changes did anything to the tests

@durack1
Copy link
Collaborator

durack1 commented Sep 18, 2014

These files are all in the test dir:

[durack1@oceanonly ~]$ ls -1 ../../140916_pcmdi_metrics/PCMDI_METRICS/test/pcmdi/
basic_test_parameters_file.py
obs
sftlf_GFDL-ESM2G_fx_historical_r0i0p0_198501-200512-clim.nc
tos_2.5x2.5_esmf_linear_metrics.json.good
tos_GFDL-ESM2G_Omon_historical_r1i1p1_198501-200512-clim.nc

The sftlf is buried under the convoluted obs subdir

@durack1
Copy link
Collaborator

durack1 commented Sep 19, 2014

Ok this is starting to look good.. All we need now is to wedge in portraits.py so it's on the (metrics install) python path and we're cooking with gas!

@durack1 durack1 merged commit 3abd808 into PCMDI:devel Sep 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants