Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pause circle ci unit tests #759

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Pause circle ci unit tests #759

merged 3 commits into from
Aug 6, 2021

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Aug 4, 2021

No description provided.

@lee1043 lee1043 self-assigned this Aug 4, 2021
@lee1043 lee1043 linked an issue Aug 4, 2021 that may be closed by this pull request
Pause unit tests on circle ci #758
Closed
@acordonez
Copy link
Collaborator

@lee1043 I've been checking in to see when the build finishes to approve - but otherwise the changes seem to have worked!

acordonez
acordonez approved these changes Aug 6, 2021
View reviewed changes
Copy link
Collaborator

@acordonez acordonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CircleCI picked up the change correctly.

@lee1043
Copy link
Contributor Author

lee1043 commented Aug 6, 2021

@acordonez thanks!

@lee1043 lee1043 merged commit dd16073 into master Aug 6, 2021
@lee1043 lee1043 deleted the 758_ljw_circleci_test_pause branch August 6, 2021 16:04
@lee1043 lee1043 linked an issue Aug 6, 2021 that may be closed by this pull request
simple check of CI #752
Closed
@lee1043 lee1043 restored the 758_ljw_circleci_test_pause branch August 12, 2021 16:07
@lee1043 lee1043 deleted the 758_ljw_circleci_test_pause branch August 12, 2021 16:08
@lee1043 lee1043 restored the 758_ljw_circleci_test_pause branch August 12, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acordonez acordonez acordonez approved these changes

@gleckler1 gleckler1 Awaiting requested review from gleckler1

Assignees

@lee1043 lee1043

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pause unit tests on circle ci simple check of CI
3 participants
@lee1043 @acordonez @gleckler1