Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary visualization: portrait and parallel coordinate plots #757

Merged
merged 65 commits into from
Oct 5, 2021

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Aug 3, 2021

No description provided.

@lee1043
Copy link
Contributor Author

lee1043 commented Aug 3, 2021

To do's:

  • Make functions to be importable (add __init__.py files)
  • Add PMP logo on portrait plot
  • Discrete colormap option
  • Generalize and simplify JSON reader for practical usage

@lee1043 lee1043 self-assigned this Aug 3, 2021
@lee1043 lee1043 linked an issue Aug 3, 2021 that may be closed by this pull request
@lee1043 lee1043 marked this pull request as ready for review September 30, 2021 00:38
@acordonez
Copy link
Collaborator

@lee1043 Are there particular jupyter notebooks or scripts I should try running?

@lee1043
Copy link
Contributor Author

lee1043 commented Sep 30, 2021

@acordonez thanks for checking. In readme files for portrait plot and parallel coordinate plot, there are two jupyter notebooks in each readme: one for example and another for use case (mean clim). Could you please check if those notebooks run well on your end?

Copy link
Collaborator

@acordonez acordonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the 4 jupyter notebooks and they are all working for me now. LGTM!

@lee1043 lee1043 merged commit 99448e1 into master Oct 5, 2021
@lee1043 lee1043 deleted the 756_ljw_visualization branch October 5, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement visualization capability
2 participants