Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoV demo #705

Merged
merged 11 commits into from
Mar 9, 2021
Merged

MoV demo #705

merged 11 commits into from
Mar 9, 2021

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Mar 8, 2021

No description provided.

@lee1043
Copy link
Contributor Author

lee1043 commented Mar 8, 2021

@acordonez Would you mind trying my latest notebook for the variability modes? Please feel free to make update on it. Many thanks!

@acordonez
Copy link
Collaborator

@lee1043 Yes I'll give this a try and let you know how it goes

@acordonez
Copy link
Collaborator

@lee1043 I'm still getting the "non-zero exit code" error in cells that run variability_modes_driver.py. Is that fix going in a different PR?
Otherwise, the other cells ran successfully.

@lee1043
Copy link
Contributor Author

lee1043 commented Mar 9, 2021

@acordonez thanks. The "non-zero" error sounds strange because that fix is included in this PR. Did you do setup.py install before you were running the notebook?

@acordonez
Copy link
Collaborator

@lee1043 I forgot to do the install! That solves the problem. Now the notebook runs successfully.

@lee1043
Copy link
Contributor Author

lee1043 commented Mar 9, 2021

@acordonez Excellent, thank you very much!

@lee1043 lee1043 merged commit 6d6f40a into master Mar 9, 2021
@lee1043 lee1043 deleted the 645_ao_modes_of_variability branch March 9, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants