Durack1 standardise regridded file delimiters #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs for regrid output files
…ng and general cleanup
|
I'm uncertain if the "ext = '.nc'/'.xml'" is used, if so this needs to be put back in |
|
we should remove this file all together the only "sample" parameters file in this whole thing that I trust is the one in the test directory: |
|
I think a more thoroughly documented file (which is what I've tried to do within this pull request) is useful to have somewhere, so a user can see how it's been used |
|
agreed but please base it on the one I pointed. It has all the valid keywords/options in it. |
|
Yep, the version is based on yours.. So the latest pcmdi_metrics master branch |
gleckler1 sftlf had isst fix @doutriaux is sitting next to me, and pressed <ENTER>
|
ask @doutriaux1 what happened |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using a mix of "_" and "." to delimit fields in the output filename - this should be consistent