Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated .circleci/config.yml to use the new conda-recipes' build_tools/conda_build.py which built the package using 'conda build' and install the built package using --use-local in the test environment.
conda-recipes' build_tools/conda_build.py also builds using conda-forge-pinning.
This way, we are really testing the package which is going to be put in pcmdi/label/nightly (if tests pass).
With this PR, you will see coverage went down to from 77% to 59%.
In the past, we ran tests with --coverage-from-egg option which does not work anymore since we built using 'conda build', and the coverage were including coverage from the test code itself which ofcourse are 100% (since we ran all testcases), as a result, you see a higher coverage number (77%) which I think can be misleading, since we really want to see the coverage on the code itself.
I also updated the name of job in the circleci workflow, instead of linux_pmp_py3, I renamed it to linux_pmp_py37.
You can ignore the linux_pmp_py3 and macos_pmp_py3, those jobs do not exist anymore.