Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modes of variability (branch: 377 variability mode nao) #623

Merged
merged 154 commits into from
Oct 23, 2019

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Oct 22, 2019

Work in progress for merging the modes variability code to the master. Please do not merge yet. The PR is not ready for merging until told by myself.

@lee1043
Copy link
Contributor Author

lee1043 commented Oct 23, 2019

@muryanto1 I think the code is ready for merging, could you please take a look when you have time? Thank you very much!

Copy link
Contributor

@muryanto1 muryanto1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test passed. Note that I am approving this PR to be merged just based on the fact that it does not break existing tests. I did not review the content of the changes as that will require me to understand the project, and my time will not allow me at this moment.
Looking at a glance, I have following questions:

  • why are there *py under pcmdi_metrics/variability_mode/doc directory? I assume 'doc' is for documentations.
  • If those *py code are supposed to run somewhere, it has hardcoded directory /work/lee1043, I am guessing that the code will fail if you run it on a machine that does not have access to that dir.
    Similarly, it has hardcoded /p/user_pub/PCMDIobs/...

@lee1043
Copy link
Contributor Author

lee1043 commented Oct 23, 2019

@muryanto1 thank you for reviewing the PR.

  • doc directory is for parameter files that serve as a namelist example, collecting user given options such as directory to find input data. Thoes parameter codes are not running by themselves but always working with *py in scripts directory.
  • I agree directory name could be better name than 'doc'. But at the moment what I need to be done is placing code in the master branch for PCMDI SFA proposal, so I will think about it later.

@lee1043 lee1043 merged commit e3b42ae into master Oct 23, 2019
@lee1043 lee1043 deleted the 377_Variability_mode_NAO branch October 23, 2019 16:45
@lee1043
Copy link
Contributor Author

lee1043 commented Oct 23, 2019

@gleckler1 MoV code is in master now. As we discussed earlier we will need to work on documentation, usage example, and test suites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants