-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modes of variability (branch: 377 variability mode nao) #623
Conversation
move to sub directory
move to sub directory
move to sub directory, scripts
…rics into 377_Variability_mode_NAO
@muryanto1 I think the code is ready for merging, could you please take a look when you have time? Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test passed. Note that I am approving this PR to be merged just based on the fact that it does not break existing tests. I did not review the content of the changes as that will require me to understand the project, and my time will not allow me at this moment.
Looking at a glance, I have following questions:
- why are there *py under pcmdi_metrics/variability_mode/doc directory? I assume 'doc' is for documentations.
- If those *py code are supposed to run somewhere, it has hardcoded directory /work/lee1043, I am guessing that the code will fail if you run it on a machine that does not have access to that dir.
Similarly, it has hardcoded /p/user_pub/PCMDIobs/...
@muryanto1 thank you for reviewing the PR.
|
@gleckler1 MoV code is in master now. As we discussed earlier we will need to work on documentation, usage example, and test suites. |
Work in progress for merging the modes variability code to the master. Please do not merge yet. The PR is not ready for merging until told by myself.