Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click top bottom #619

Merged
merged 7 commits into from
Oct 23, 2019
Merged

Click top bottom #619

merged 7 commits into from
Oct 23, 2019

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Sep 30, 2019

@doutriaux1 helped advancing followings on interactive portrait plot using click:

  • Show up x-axis at top and/or bottom
  • Turn on/off clickable capability for x- or y- labels.

PCMDI/click#23

@lee1043
Copy link
Contributor Author

lee1043 commented Oct 2, 2019

@gleckler1 could you please approve this change? You were assigned as the reviewer. Change is for the interactive portrait plot.

@lee1043 lee1043 requested review from muryanto1 and removed request for gleckler1 October 7, 2019 20:12
@coveralls
Copy link

coveralls commented Oct 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1435

  • 15 of 17 (88.24%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 76.785%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pcmdi_metrics/graphics/portraits.py 13 15 86.67%
Files with Coverage Reduction New Missed Lines %
pcmdi_metrics/graphics/portraits.py 1 39.04%
Totals Coverage Status
Change from base Build 1428: 0.03%
Covered Lines: 3258
Relevant Lines: 4243
💛 - Coveralls

@lee1043
Copy link
Contributor Author

lee1043 commented Oct 23, 2019

@muryanto1 I think this PR is also ready to merge, could you please review?

@lee1043 lee1043 merged commit 5278958 into master Oct 23, 2019
@lee1043 lee1043 deleted the click_top_bottom branch October 23, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muryanto1 muryanto1 muryanto1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lee1043 @coveralls @muryanto1 @doutriaux1