Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

594 ljw improve monsoon sperber #596

Merged
merged 38 commits into from
Oct 23, 2019
Merged

594 ljw improve monsoon sperber #596

merged 38 commits into from
Oct 23, 2019

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Mar 14, 2019 •
edited
Loading

PR for tracking changes... yet to be ready for merging...

Connected issue: #594

@lee1043 lee1043 mentioned this pull request May 24, 2019
Closed
2 tasks
@lee1043
Copy link
Contributor Author

lee1043 commented Sep 18, 2019

@gleckler1 as a part of cleaning I think this could be merged to master and delete corresponding issue.

@lee1043 lee1043 requested a review from muryanto1 October 8, 2019 18:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1452

  • 1 of 7 (14.29%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 76.744%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pcmdi_metrics/monsoon_sperber/argparse_functions.py 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
pcmdi_metrics/monsoon_sperber/argparse_functions.py 2 6.25%
Totals Coverage Status
Change from base Build 1428: -0.01%
Covered Lines: 3257
Relevant Lines: 4244
💛 - Coveralls

@lee1043
Copy link
Contributor Author

lee1043 commented Oct 23, 2019

@muryanto1 I see all test passes except coverage/coveralls, which I am not familiar about. Could you please give some clue what it is for?

@lee1043
Copy link
Contributor Author

lee1043 commented Oct 23, 2019

@muryanto1 and thank you very much for reviewing! :)

@lee1043 lee1043 merged commit 0bbec22 into master Oct 23, 2019
@lee1043 lee1043 deleted the 594_ljw_improve_monsoon_sperber branch October 23, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muryanto1 muryanto1 muryanto1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lee1043 @coveralls @muryanto1