Switch to setuptools

[doutriaux1]

No description provided.

[coveralls]

Pull Request Test Coverage Report for Build 740

• 203 of 229 (88.65%) changed or added relevant lines in 13 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+28.2%) to 73.763%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pcmdi_metrics/driver/outputmetrics.py	0	1	0.0%
pcmdi_metrics/pcmdi/mean_climate_metrics_driver.py	38	39	97.44%
tests/basepmpdriver.py	14	18	77.78%
pcmdi_metrics/monsoon_wang/monsoon_wang_driver.py	110	116	94.83%
tests/test_pmp_diurnal.py	15	21	71.43%
tests/test_monsoon_wang.py	8	16	50.0%

Totals
Change from base Build 675:	28.2%
Covered Lines:	2817
Relevant Lines:	3819

---

💛 - Coveralls

[doutriaux1]

@muryanto1 I have to look at this carefully again. Even though I technically didn't touch any code (just reshuffling) It says big drop in coverage. Do you think it's because of bin files? They're now called via entry_point. Maybe some test silently fail... At least we can now see the coverage in files from the PR. Which was the goal on this PR.

[muryanto1]

Charles, I need to fix testsrunner.
It made an assumption for subprocesses that they are from the conda env. It needs to check if --coverage-from-repo is specified.

[doutriaux1]

@muryanto1 it finally passes all os and ci systems. Please review.

[doutriaux1]

@durack1 @gleckler1 @lee1043 please take a look as well, there's no new functionalities, but this gives us, better coverage report and ONE common upload for all OSes and Python flavors.

[gleckler1]

@durack1 @gleckler1 @lee1043. I am ok with the dir/filename reorg. Is the test suite sufficiently comprehensive to check that nothing has broken? Probably we should rerun all of our CMIP5 results soon to verify.

[doutriaux1]

@gleckler1 it's one the bonus things, the "coverage" is now reporting a 14% increase, because we can now report on coverage from tests launch in subprocess. Total coverage for the test suite says 60.5%. But most of it comes from test. Actually I see that diurnal tests coverage is not being reported. I'll take a look in another PR. @muryanto1 can you help me investigate this?. See: https://coveralls.io/builds/19960332

[doutriaux1]

@muryanto1 actually we're still not reporting coverage correctly on things coming from subprocesses... Such a pain. I see nothing from diurnal and most of the code ran by metrics driver is left uncovered...

[durack1]

@doutriaux1 once this is in, there will NEED to be a new release. 1.2 from Sept is a long time, and many code/dir/org changes ago

[gleckler1]

@doutriaux1 @durack1 New release is fine but we need to have examples in it and that is contingent on C and Z getting CDP working with code in input param files.

[doutriaux1]

@gleckler1 I'm trying to contact @zshaheen to understand how to trigger his changes.

[gleckler1]

@doutriaux1 I just thought of a possible headache with this restructuring. I have many branches ~10 which are under gradual development. How are the directory and filename changes going to be handled when these are eventually merged with master?

[doutriaux1]

@gleckler1 if it's not a new file it will be migrated smoothly. If not I'll help you do the cleanup.