portrait plot bug fix in python 3 env #582
Conversation
…ns integer/integer = float
There was a problem hiding this comment.
@lee1043 beside my comment, everything looks good, you could add a test that verify that the error is indeed fixed (a small portrait plots with len(cols) / 3 being odd or something, but it's not really needed here. Also I pushed a fix for flake8, it had become a bit more strict and issues more warnings.
src/python/graphics/portraits.py
Outdated
| @@ -1939,7 +1939,7 @@ def set_colormap(self): | |||
| 92.9412, | |||
| 100) | |||
|
|
|||
| cols = MV2.reshape(cols, (len(cols) / 3, 3)) | |||
| cols = MV2.reshape(cols, (int(len(cols) / 3), 3)) | |||
There was a problem hiding this comment.
@lee1043 we should probably use:
cols = MV2.reshape(cols, (len(cols) // 3, 3))But I will leave it up to you.
There was a problem hiding this comment.
@doutriaux1 like the idea. Thanks!
|
@lee1043 feel free to merge if tests pass. |
…DI/pcmdi_metrics into 581_ljw_portraitPlot_python3
|
@doutriaux1 hmm... it says travis-ci fails, not sure what to do. May I hand over this to you? |
|
@doutriaux1 travis still fails.... |
|
@lee1043 yes, it was expected, but output should be more readable now. |
#581
make sure integer number used for reshape array, where python 3 returns integer/integer = float