first cut at getting a data downloader #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durack1
reviewed
Oct 4, 2018
| parser.add_argument("--dataset", help="Download observation or sample data or both", | ||
| default="all", choices=["all", "obs", "sample"]) | ||
| parser.add_argument("--version", help="which version to use", default="latest") | ||
| parser.add_argument("--server", help="which serverto use", |
durack1
reviewed
Oct 4, 2018
| parser.add_argument("--server", help="which serverto use", | ||
| default="https://pcmdiweb.llnl.gov/pss/pmpdata") | ||
| parser.add_argument("--version_in_path", action="store_true", default=False, | ||
| help="Append version in rooot path, avoids clobbering versions") |
zshaheen
approved these changes
Oct 4, 2018
|
@zshaheen I'll try to add a test though... |
|
@doutriaux1 this is not in nightlies yet is it? Can I conda install this? |
|
@durack1 I would like you or Peter to test it first a bit. |
|
@doutriaux1 on my list but its a messy week! |
|
No worries. I got quite a week as well so I can wait! |
|
@gleckler1 do you think you can review/try this today? |
|
@doutriaux1 easy to use and working well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gleckler1 @durack1 please review @zshaheen you too please if you have time