Diurnal test off #575
Diurnal test off #575
Conversation
Test were expecting same pattern for all json file, but it depends on the script ran, added a parm to runJSONEr for this Input datsa where expcted to be in some local directory but they are now pre-downloaded by test suite and in cdat_info.get_sampledata_path() location
doutriaux1
requested review from
durack1,
zshaheen,
muryanto1 and
gleckler1
|
@doutriaux1 Is this working with param file we were test last Thurs? |
|
No this is the test suite itself, turns out most tests were turned off.... |
|
@doutriaux1 OK.... any luck with getting the param file working? |
|
baby steps @gleckler1 |
| @@ -77,7 +77,7 @@ def compute(params): | |||
| nlats = dimensions[1] | |||
| nlons = dimensions[2] | |||
| deltaH = 24. / N | |||
| dayspermo = tvarb.shape[0] / N | |||
| dayspermo = tvarb.shape[0] // N | |||
There was a problem hiding this comment.
Just to be safe, you might want to have from __future__ import division. This will use the Python 3 way of dividing, if that's what you wanted. I'm not too sure if that's what you were aiming for however.
There was a problem hiding this comment.
you're right @zshaheen updating now, I'm surpised py2 passed.
|
@doutriaux1 For whatever reason - I'll take it - diurnal example param file is now working. |
|
@gleckler1 look at you, all brave and confident! Thx! |
No description provided.