404 jwl pentmonsoon #563
404 jwl pentmonsoon #563
Conversation
There was a problem hiding this comment.
@doutriaux1 thanks for working on this. I think it is ready to be merged.
|
@lee1043 the test suite is still failing on mac. I'll take a look today. |
|
@doutriaux1 thanks for following up. Wondering what kind of failure appear? |
|
looks like graphic tests |
|
@doutriaux1 is that the numpy warning message? |
|
nope it's a conda related bug: https://401-10345204-gh.circle-artifacts.com/0/tests_html/test_pmp_pcoords.html |
|
@doutriaux1 okay thanks for fixing it! |
|
@doutriaux1 is there anything further I need to do before it to be merged? Please let me know, thanks. |
|
@lee1043 please do not push to this branch! Especially debug print statements! I'm trying to bring it into master! |
|
Currently the failure are not directly related to your branch |
|
@doutriaux1 oops..... sorry. okay, no more pushing... |
monsoon sperber metrics