Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cia unify part one #528

Merged
merged 6 commits into from
Mar 23, 2018
Merged

Cia unify part one #528

merged 6 commits into from
Mar 23, 2018

Conversation

doutriaux1
Copy link
Contributor

No description provided.

@doutriaux1
Copy link
Contributor Author

@gleckler1 @durack1 it's now using CIA for monsoon and dirunal

But in order for this to pass we need to reslove: #527

@gleckler1
Copy link
Contributor

@doutriaux1 The big leap is getting monsoon and dirunal working with CIA using a parameter file. It looks like these changes are just for the command line (argparse) path. Is that correct?

@durack1
Copy link
Collaborator

durack1 commented Mar 19, 2018

@doutriaux1 not sure I'm going to get to run this to thoroughly check - is the test suite testing this new code?

@doutriaux1
Copy link
Contributor Author

@gleckler1 they should work with a parameter file. I'll check.

@gleckler1
Copy link
Contributor

@doutriaux1 Need to get this to work. Now setup.py won't run on branch origin/cia_unify_part_one. looks like a py3 issue...

I've been trying to create an env (below) with pcmdi_metrics and cia and a parameter file... I've blown 1/2 so far, still can't do it...

conda create -n pmp_mar21 -c uvcdat/label/nightly -c conda-forge -c uvcdat -c pcmdi/label/nightly -c pcmdi vcs vcsaddons pcmdi_metrics cia

@doutriaux1
Copy link
Contributor Author

@gleckler1 let's look in the morning

@doutriaux1 doutriaux1 merged commit 44c9d88 into master Mar 23, 2018
@doutriaux1 doutriaux1 deleted the cia_unify_part_one branch March 23, 2018 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants