Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py3 #526

Merged
merged 20 commits into from
Mar 22, 2018
Merged

Py3 #526

merged 20 commits into from
Mar 22, 2018

Conversation

doutriaux1
Copy link
Contributor

All done. Py3 fails because it runs with esmf 7.1 which is different form 7.0 (py2 fails both from master or this with esmf 7.1)

@durack1
Copy link
Collaborator

durack1 commented Feb 23, 2018

@doutriaux1 time for a new baseline with ESMF7.1 (if we get comparable results using regrid2 for the atmos grids)

@gleckler1

@doutriaux1
Copy link
Contributor Author

@gleckler1 thiking of switching the tests to use linear at least until CDAT/cdms#231 is fixed. What do you think?

@durack1
Copy link
Collaborator

durack1 commented Feb 23, 2018

@doutriaux1 I think we really need to work through this one with @dnadeau4 and make sure that the defaults are giving the results that a user expects - it's a powerful regridder, but default outputs are VERY important

@doutriaux1
Copy link
Contributor Author

@durack1 agreed, that's why we could also disable conservative completely at the moment and raise an error, until this bug is addressed. Thoughts?

@durack1
Copy link
Collaborator

durack1 commented Feb 23, 2018

@doutriaux1 this is not released, right? A warning would be a good idea until the behaviour is acceptable

@gleckler1
Copy link
Contributor

@doutriaux1 @dnadeau4 @durack1 Seems like a good thing to do if not too onerous. I have told the E3SM people using the PMP to not use ESMF conservative until we resolve this, but maybe better is to disable for now.

@doutriaux1
Copy link
Contributor Author

ok will disable on Monday and merge this in master.

@doutriaux1 doutriaux1 merged commit f9fedbb into master Mar 22, 2018
@doutriaux1 doutriaux1 deleted the py3 branch March 22, 2018 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants