Diurnal [WIP] #510
Merged
Diurnal [WIP] #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut.py Added capability to append to json files
generate sftlf if not found works
correct output names
|
@durack1 @gleckler1 this is ready to be approved and go in |
|
@doutriaux1 should we wait for a green light with the tests? Or do we still have the precision issue causing the red crosses? |
|
It's green now. |
durack1
reviewed
Dec 22, 2017
| @@ -1,44 +1,44 @@ | |||
| import cdutil | |||
|
|
|||
| regions_specs = { | |||
| 'NHEX': {'domain': cdutil.region.domain(latitude=(30., 90, 'ccb'))}, | |||
There was a problem hiding this comment.
@doutriaux1 why was this truncated?
There was a problem hiding this comment.
No idea. Let me put it back in. Nice catch.
There was a problem hiding this comment.
@durack1 "ccb" is not used by cdutil.domain it can only break things and confuse newer users.
durack1
reviewed
Dec 22, 2017
src/python/diurnal/common.py
Outdated
| "--append", | ||
| default=False, | ||
| action="store_true", | ||
| help="append in json file in json exist (e.g. adding a model to file)") |
There was a problem hiding this comment.
"append in json file in json exist (e.g. adding a model to file)" -> "append in json file if json exists (e.g. adding a model to an existing file)"
durack1
reviewed
Dec 22, 2017
src/python/diurnal/fourierFFT.py
Outdated
| Do NOT detrend the time series first, in order to retain the "sawtooth" frequency implied by the input length of the | ||
| time series (e.g. the 24-hour period from a composite-diurnal cycle). | ||
|
|
||
| On input: x[i, j] = values at each gridpoint (i) for N times (j), e.g. N = 8 for a 3-hr composite-diurnal cycle |
There was a problem hiding this comment.
Extra spaces in doc string
durack1
reviewed
Dec 22, 2017
| Do NOT detrend the time series first, in order to retain the "sawtooth" frequency implied by the input length of the | ||
| time series (e.g. the 24-hour period from a composite-diurnal cycle). | ||
|
|
||
| On input: x[k,i,j] = values at each gridpoint (i,j) for N times (k), e.g. N = 8 for a 3-hr composite-diurnal cycle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to add test suite