Issue413 durack1 pcmdi logo for branding #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doutriaux1 it seems the portrait issue is still alive in this PR can you take a look please? |
|
@durack1 push and pr behave differently, I think one merges master in first the other not. Try to merge master into that branch |
|
@doutriaux1 ok trying again.. This might be a case of needing to merge #417 into master before updating this branch again.. |
|
@doutriaux1 ok good to go |
|
@durack1 I'll edit this branch to actually use the logo, before merging. Ok? |
|
@doutriaux1 perfect, it would be better to actually be using these rather than just dumping them.. So please go ahead.. |
|
@doutriaux1 the quality of the images are pretty terrible - both the logo and the text for the colorbar, and the top of the colorbar too, see below: |
plots logo last to make sure no call to update is done after it which would erase it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #413 - Added png logos for branding
@gleckler1 @doutriaux1 as discussed in #413 - oblong is the non-gridded version