Issue 221 add metrics doc in json #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "Contact":"[email protected]", | ||
| } | ||
| else: | ||
| out["some_custom"]=1.5 | ||
| return out | ||
| compute_custom_metrics = my_custom |
There was a problem hiding this comment.
It'd be great to include an example of how a user defines custom_observations as per https://github.com/PCMDI/pcmdi_metrics/pull/244/files
Same story for the regions as per #252
|
@doutriaux1 is this all good to go? |
Reordered a bit filling of metrics dict in compute the for loop was useless edited param file so that custom func work with metrics defs
doutriaux1
force-pushed
the
issue_221_add_metrics_doc_in_json
branch
from
aa996e5
to
f6923d9
Compare
|
@durack1 care to merge it now that it's rebased? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@durack1 @gleckler1 @jservonnat this adds metrics info at bottom of files.
We can further tweaks the dictonaries keywords, etc.. but that's the idea. Please review and comment