Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue217 durack1 demo for csiro data #218

Merged
merged 4 commits into from
Jan 21, 2015

Conversation

durack1
Copy link
Collaborator

@durack1 durack1 commented Jan 21, 2015

@doutriaux1 please take a look and merge ASAP

@durack1
Copy link
Collaborator Author

durack1 commented Jan 21, 2015

@doutriaux1 actually hang 5 while I also update setup.py to pull these files across during installation..

@durack1
Copy link
Collaborator Author

durack1 commented Jan 21, 2015

@doutriaux1 she's good to go.. Merge when you can..

@doutriaux1
Copy link
Contributor

ok now I'm nervous I don't like you touching setup.py ;)

@doutriaux1
Copy link
Contributor

lgtm all these demo starting to be a bit redundant and add a lot of noise we should probably have an option in the install script to turn these on/off or just install one

doutriaux1 added a commit that referenced this pull request Jan 21, 2015
@doutriaux1 doutriaux1 merged commit 67d0c14 into PCMDI:master Jan 21, 2015
@doutriaux1 doutriaux1 deleted the issue217_durack1_DemoForCSIROData branch January 21, 2015 20:11
@durack1
Copy link
Collaborator Author

durack1 commented Jan 21, 2015

@doutriaux1 well they are hidden in the demo subdir and subdirs beneath them.. The reason I want them in there is that each demo has taken a different path to get the results.. So GFDL required variable remapping, NCAR requires variable remapping and interpolation, CSIRO requires the use of a qsub/quota system to actually use the metrics package.. So I think they're all useful and provide us/me with a quick template to point new users toward..

@doutriaux1
Copy link
Contributor

i understand that. nd I'm fine with having them in the repo. Just not quite sure it's worth installing an every users' systems.

@durack1
Copy link
Collaborator Author

durack1 commented Jan 21, 2015

@doutriaux1 as discussed.. In my head this then provides a ready reference that is available to all users who have successfully installed.. If I was leading a new user through preparing their data and using the package I'd select from one of the 4 test cases, which are all sitting in front of them.. It's easier to point them to the demo subdir than for them to hunt around in the tmp subdirs, or to try and figure out how to get a file from github down to their systems..

I agree if these grow ridiculously we might want to trim things, but I think more examples are more useful than less..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants