Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue161 durack1 1p0p0 final tweaks #212

Merged
merged 4 commits into from
Jan 14, 2015

Conversation

durack1
Copy link
Collaborator

@durack1 durack1 commented Jan 14, 2015

@doutriaux1 these are all updated after running at GFDL, so they are all valid, tested and accurate with paths etc - please merge when you can

Also ran the test case and it returned 6 passes:

----------------------------------------------------------------------
Ran 6 tests in 77.710s

OK
public1:/home/p1d/150113_metrics/PCMDI_METRICS>

@gleckler1 you might want to check the demo/GFDL subdir pngs to make sure they're what you wanted..

@gleckler1
Copy link
Contributor

2 obs comparison will be cleaner than 3 obs
p

From: "Paul J. Durack" <[email protected]mailto:[email protected]>
Reply-To: PCMDI/pcmdi_metrics <[email protected]mailto:[email protected]>
Date: Tuesday, January 13, 2015 4:56 PM
To: PCMDI/pcmdi_metrics <[email protected]mailto:[email protected]>
Cc: gleckler1 <[email protected]mailto:[email protected]>
Subject: [pcmdi_metrics] Issue161 durack1 1p0p0 final tweaks (#212)

@doutriaux1https://github.com/doutriaux1 these are all updated after running at GFDL, so they are all valid, tested and accurate with paths etc - please merge when you can

Also ran the test case and it returned 6 passes:


Ran 6 tests in 77.710s

OK
public1:/home/p1d/150113_metrics/PCMDI_METRICS>

@gleckler1https://github.com/gleckler1 you might want to check the demo/GFDL subdir pngs to make sure they're what you wanted..


You can merge this Pull Request by running

git pull https://github.com/durack1/pcmdi_metrics issue161_durack1_1p0p0FinalTweaks

Or view, comment on, or merge it at:

#212

Commit Summary

  • Merge branch 'pcmdi_master'
  • Update install_metrics.bash to build VTK/VCS and setup_runtime. shell specific
  • Updated install_metrics.bash to turn VTK/VCS building back off by default
  • Updated all GFDL demo files from 150113_metrics test dir on public1

File Changes

Patch Links:


Reply to this email directly or view it on GitHubhttps://github.com//pull/212.

@doutriaux1
Copy link
Contributor

yes but 3 shows off better that we can do ANY number and the code follows not powers of 2.

doutriaux1 added a commit that referenced this pull request Jan 14, 2015
@doutriaux1 doutriaux1 merged commit 11d71de into PCMDI:master Jan 14, 2015
@durack1 durack1 deleted the issue161_durack1_1p0p0FinalTweaks branch January 14, 2015 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants