Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update central arctic domain #1076

Closed
wants to merge 1 commit into from
Closed

Update central arctic domain #1076

wants to merge 1 commit into from

Conversation

acordonez
Copy link
Collaborator

This PR expands the central arctic domain to remove the masking for the pole hole. On closer reading of the Ivanova (2016) paper, the pole hole was only masked for the ice edge analysis but not for the total ice area analysis.

@acordonez acordonez requested a review from lee1043 April 3, 2024 17:21
@lee1043
Copy link
Contributor

lee1043 commented Apr 3, 2024

@acordonez Thank you for the PR. If I understood correctly, before this PR, the sea-ice metric removes the pole hole by masking it out because there is no observation. With this PR, the metric will include the sea-ice area in the pole hole. Is that right? Is there any chance that this PR could make the model looking like overestimating the sea-ice extent in case model does good job, because the model has data over the pole hole (that is counted for sea-ice area) while observation does not (thus not counted for sea-ice area)?

I think it is okay to improve metrics beyond what Ivanova (2016) did. I am tagging @gleckler1 and @durack1 for their insights.

@acordonez
Copy link
Collaborator Author

@lee1043 That's correct. The OSI-SAF data we're using does have data over the hole, not sure how that's accomplished.

@acordonez
Copy link
Collaborator Author

@lee1043 Also looking at this code we've been including the sea ice data over the pole in the whole Arctic metrics, but not the central arctic metrics. If we do decide to mask the hole then I need to update the total Arctic region.

@lee1043
Copy link
Contributor

lee1043 commented Apr 25, 2024

@acordonez Do you think this exclusion of pole hole can be set as optional capability with a parameter accompanying with?

@lee1043
Copy link
Contributor

lee1043 commented Apr 30, 2024

Note: pole option added by #1087

@acordonez please feel free to merge

@acordonez acordonez closed this Apr 30, 2024
@acordonez acordonez deleted the ao_si_patch branch April 30, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants