Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify demo 9b #1053

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Simplify demo 9b #1053

merged 2 commits into from
Feb 7, 2024

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Feb 7, 2024

Demo 9b is simplified by removing the interactive visualization part.

@lee1043 lee1043 self-assigned this Feb 7, 2024
@lee1043 lee1043 added the demo label Feb 7, 2024
@lee1043 lee1043 marked this pull request as ready for review February 7, 2024 00:14
@lee1043
Copy link
Contributor Author

lee1043 commented Feb 7, 2024

I removed the interactive visualization part considering time limit, and also some of them was not working properly on Nimbus binder hub.

Copy link
Collaborator

@durack1 durack1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lee1043 a quick diff glance looks like this has simplified things a lot!

Copy link
Collaborator

@acordonez acordonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in this version worked for me on gates and Nimbus.

@lee1043
Copy link
Contributor Author

lee1043 commented Feb 7, 2024

@acordonez @durack1 thanks for checking!

@lee1043 lee1043 merged commit 5a9f5ee into main Feb 7, 2024
5 checks passed
@lee1043 lee1043 deleted the lee1043-patch-3 branch February 7, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants