-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MoV code to use xCDAT #1020
Merged
Merged
Changes from 1 commit
Commits
Show all changes
101 commits
Select commit
Hold shift + click to select a range
7c54910
add more stats for MoV driver
lee1043 86ca9b2
update
lee1043 a15e5c8
update eofs to v1.4.1
lee1043 8ca46ad
clean up
lee1043 9cc5783
pre-commit fix
lee1043 05fafeb
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 5dc869f
some functions moved to io
lee1043 585c867
clean up
lee1043 1579cf1
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 80dbdba
update
lee1043 60feadc
clean up
lee1043 53ec879
duplicate string constructor to io because of circular import error
lee1043 1e2073f
pre-commit fix
lee1043 ed93d69
use fill_template from io instead of utils
lee1043 79902b7
use calcTCOR from newer position and pre-commit fix
lee1043 e4d3498
update
lee1043 a087755
update
lee1043 348b859
clean up, add regrid utils
lee1043 ccbc08d
debug and updates
lee1043 02d3068
bug fix (continue)
lee1043 a0a716a
bug fix
lee1043 0fa57f6
add north test as a part of the driver
lee1043 ce979f7
bug fix
lee1043 e495fee
bug fix
lee1043 8a606bc
pre-commit fix
lee1043 ad84f7a
clean up
lee1043 2d89f57
pre-commit fix
lee1043 3c1a873
bug fix
lee1043 60772d4
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 052d3e8
bug fix
lee1043 c1a28b1
bug fix
lee1043 8d10543
simplify, clean up, add link to PMP installation
lee1043 6bb67ae
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 64a8b31
add logo and clean up in the demo notebook
lee1043 28e6cf8
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 f968029
clean up
lee1043 5f039de
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 8c8caeb
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 f2c1593
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 426e7fc
logic simplified
lee1043 8d4f9de
clean up
lee1043 6bc7232
update
lee1043 84e5f9d
Merge pull request #1060 from PCMDI/feature/lee1043-mov-modularize
lee1043 fbca25c
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 c9c5d3c
make code calender flexible -- reduced calendar dependency
lee1043 131df5c
pre-commit fix
lee1043 65b69c4
bug fix
lee1043 cf6fb8a
move timeseries adjustment in a new separate file
lee1043 ae02779
Merge branch 'feature/1012_lee1043_stats-MoV_xcdat' into feature/lee1…
lee1043 dd09f56
Merge pull request #1062 from PCMDI/feature/lee1043-mov-modularize
lee1043 be22674
separate adjust timeseries
lee1043 5f9ca3e
clean up
lee1043 51af8ca
Merge branch 'feature/1012_lee1043_stats-MoV_xcdat' of github.com:PCM…
lee1043 dd91e78
clean up
lee1043 3df31a1
update
lee1043 0544c51
Merge branch 'feature/1012_lee1043_stats-MoV_xcdat' of github.com:PCM…
lee1043 12ed70b
clean up
lee1043 156a3e4
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 cc569fb
rename to simplify
lee1043 8cdfa78
clean up + bug fix
lee1043 61da5b6
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 496ed5f
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 3b2dceb
pre-commit fix
lee1043 8ec3dac
clean up
lee1043 000fe20
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 9c09dc4
add demo script but for pcmdi internal
lee1043 81c794f
bug fix
lee1043 db0a396
bug fix
lee1043 00fc735
add missing bounds for sanity check
lee1043 f2f6736
in progress...
lee1043 0e18825
clean up..
lee1043 31c4298
fix bug for SAM region
lee1043 c6f6a81
enable automatic assignment of eofn_obs and eofn_mod by mode name
lee1043 f84c310
pre-commit clean up
lee1043 dee6096
remove eofn_obs and eofn_mod from pcmdi params
lee1043 77158d4
clean up
lee1043 6b2a562
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 a5fa6cd
bug fix
lee1043 219334b
bug fix for sign flip -- revealed by SAM test
lee1043 f48ea9a
update required xcdat version regarding https://github.com/PCMDI/pcmd…
lee1043 5880600
pre-commit fix
lee1043 5ad2b21
moved missing bounds adding to io function
lee1043 376bffb
bug fix for centered rmse
lee1043 b115384
pre-commit fix
lee1043 b14c5fb
reduce potential memory usage
lee1043 719d4a3
bug fix: normalize by map std for centered RMSE calculation
lee1043 c4d2791
keep updated
lee1043 113d045
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 d886049
clean up and simplified
lee1043 6a414c6
Merge branch 'feature/1012_lee1043_stats-MoV_xcdat' of github.com:PCM…
lee1043 436cfc9
initial commit for custom season capability
lee1043 e600190
add custom season capability
lee1043 b9e5aea
updated notebook to include custom season
lee1043 c6d9e3c
Merge pull request #1085 from PCMDI/feature/1012_lee1043_stats-MoV_xc…
lee1043 5aac6f7
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 abbbd9a
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 91bb1c9
bug fix
lee1043 1392682
clean up
lee1043 893c5b3
pre-commit fix
lee1043 04829b1
Merge branch 'main' into feature/1012_lee1043_stats-MoV_xcdat
lee1043 2bd8aec
clean up, more debug printout added
lee1043 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shiheng found bug in this line when file is named like “file_name_1.nc”. This fix should work well either cases like file is named like “file_name_1.nc” or “file.name.1.nc”
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During the mean time, his comment was "I’ve checked the first EOF mode of PDO. The result looks good to me."