string constructor #1008
Merged
string constructor #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No noticeable error found from all Demo notebooks. |
|
@acordonez Could you please review when you get a chance? I don't think this PR would need line by line review as the change is scattered across many file, but in general, change is for replacing Most of changes in the PR is resulted by hosting the |
|
@lee1043 Yes I'll give it a run on my end! |
|
@lee1043 I ran mean climate and mjo demos and they both finished successfully. |
acordonez
approved these changes
Dec 19, 2023
|
@acordonez thank you, I am merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from genutil import StringConstructoris replaced byfrom pcmdi_metrics.utils import StringConstructor