Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Land sea mask generation #1006

Merged
merged 11 commits into from
Dec 18, 2023
Merged

Land sea mask generation #1006

merged 11 commits into from
Dec 18, 2023

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Dec 16, 2023

  • Add the land sea mask generation capability using regionmask
  • Replace CDAT's landseamask generation to the new function
    • mean climate
    • precipitation variability

@lee1043
Copy link
Contributor Author

lee1043 commented Dec 16, 2023

Sanity check:

  • demo 1b notebook results are consistent -- mostly identical numbers
  • demo 7 notebook results are consistent -- statistics differ from 3rd from decimal point

@lee1043 lee1043 marked this pull request as ready for review December 16, 2023 07:13
@lee1043 lee1043 marked this pull request as draft December 17, 2023 07:23
@lee1043 lee1043 self-assigned this Dec 17, 2023
@lee1043 lee1043 marked this pull request as ready for review December 17, 2023 19:16
@acordonez
Copy link
Collaborator

I'll test this out in the extremes metrics branch

@acordonez
Copy link
Collaborator

@lee1043 This looks fine to me:

Untitled

@acordonez
Copy link
Collaborator

@lee1043 This looks fine to me:

Untitled

I actually did not implement the new mask correctly and I believe this is using the pcmdi_utils version...still working on testing the extremes

@lee1043
Copy link
Contributor Author

lee1043 commented Dec 18, 2023

@acordonez Thank you for checking. Please let me know when you done testing this with extreme branch. If merging this PR into main would better help your testing of extreme branch, I can also do that.

@acordonez
Copy link
Collaborator

acordonez commented Dec 18, 2023

@lee1043 This time I should be using the new land/sea mask, I pulled all the other code out of my branch:

Uploading Screenshot 2023-12-18 at 3.31.59 PM.png…

@lee1043 lee1043 merged commit c6d5398 into main Dec 18, 2023
5 checks passed
@lee1043 lee1043 deleted the feature/1005_lee1043_land-sea-mask branch December 18, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants