Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vcs dependencies #785

Closed
lee1043 opened this issue Nov 2, 2021 · 3 comments · Fixed by #797 or #793
Closed

Remove vcs dependencies #785

lee1043 opened this issue Nov 2, 2021 · 3 comments · Fixed by #797 or #793
Assignees

Comments

@lee1043
Copy link
Contributor

lee1043 commented Nov 2, 2021

Remove dependencies to vcs of CDAT because it is planned to be no longer maintained.

@lee1043 lee1043 self-assigned this Nov 2, 2021
@lee1043
Copy link
Contributor Author

lee1043 commented Nov 3, 2021

In my attempt to replace vcs by cartopy, followings were noticed (leaving for documenting).

  • @msahn and I have observed some conflict in conda env that prevents installing cartopy in the PMP-installed conda env. As a workaround, @msahn has used basemap in his plotting work, but basemap is no longer maintained and supposed to be replaced by cartopy.
  • I think I found where the conflict was caused: proj4 and cartopy, specifically proj that is one of dependencies of cartopy.
  • I don't see proj4 explicitly used in PMP. Plus, proj is supposed to replace proj4 according to this doc.
  • So I think it is okay to remove proj4 and add cartopy in dev.yml.

@gleckler1 @acordonez I don't think I've seen any code that use proj4, have you seen/used it in any code of PMP?

In @tomvothecoder's PR the proj4 was included because it was listed in meta.yaml.in from here: https://github.com/PCMDI/pcmdi_metrics/blob/8993d51c23cf8dd7abcc418acc5bbc8ef90fe645/recipe/meta.yaml.in. Is that correct?

@lee1043 lee1043 linked a pull request Nov 3, 2021 that will close this issue
@acordonez
Copy link
Collaborator

@lee1043 I haven't seen proj4 explicitly imported. I'm guessing it was a dependency for something else.

@tomvothecoder
Copy link
Collaborator

tomvothecoder commented Nov 3, 2021

In @tomvothecoder's PR the proj4 was included because it was listed in meta.yaml.in from here: https://github.com/PCMDI/pcmdi_metrics/blob/8993d51c23cf8dd7abcc418acc5bbc8ef90fe645/recipe/meta.yaml.in. Is that correct?

Correct, proj4 was in the old meta.yaml.in so it was copied over.

In my attempt to replace vcs by cartopy, followings were noticed (leaving for documenting).

  • @msahn and I have observed some conflict in conda env that prevents installing cartopy in the PMP-installed conda env. As a workaround, @msahn has used basemap in his plotting work, but basemap is no longer maintained and supposed to be replaced by cartopy.
  • I think I found where the conflict was caused: proj4 and cartopy, specifically proj that is one of dependencies of cartopy.
  • I don't see proj4 explicitly used in PMP. Plus, proj is supposed to replace proj4 according to this doc.
  • So I think it is okay to remove proj4 and add cartopy in dev.yml.

Based on your findings, I will

Related to PR #790

@lee1043 lee1043 linked a pull request Nov 5, 2021 that will close this issue
3 tasks
@lee1043 lee1043 linked a pull request Nov 11, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants