-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test suite needsdata to test udunits pkg #52
Comments
How do 66Kb and 204Kb files grab you? I can provide tos and pr (pr was the variable that appeared to need the udunits call). The tos file (GFDL) has units of "degC" and the obs (NOAA-OISST-v2) has units of "K". |
sounds perfectly reasonable |
Oh and the files have absolutely no history or metadata.. Did you want me to update these with some info as to where they've been obtained from, when, who etc? |
@doutriaux1 let me know if you need anything more else from me here - it would be a good idea to add another test with the issue described in #68 - this issue should be magically dealt with by the software, rather than the issue we're hitting.. And possibly throwing an error statement to let the user know they their data has problems (if that is the cause) |
@doutriaux1 what do you need data-wise for this? There are some GFDL-ESM2G files hanging off: oceanonly.llnl.gov slash durack1/dump/140808_metrics |
@doutriaux1 what else do you need for this, is this closed via #145? |
no we do not test for wrong/different units in this case. |
@doutriaux1 both TAS and TOS fields with the GFDL units (degrees_C) are findable at the URL (broken) above, and repeated here: oceanonly.llnl.gov slash durack1/dump/140808_metrics |
@doutriaux1 this is 1 of 4 open issues which are associated with the 1.0 milestone.. Any work required on this or is it closeable? |
let me see if I could reuse some of the example data we have via a cdscan and alter units even though it would lead to wrong result, we could check that we indeed get the wrong results, hence udunits worked |
@doutriaux1 I don't think you need too.. The GFDL-ESM2G files that are findable at the links above should trigger UDUNITS.. |
how big are they. i'm trying to keep the repo small |
66KB and 204KB as it says in #52 (comment) |
I should learn to read.... |
I do try to be overly verbose in my comments.. You should know this by now.. |
though I've just noted that I gave you TAS and TOS, and not PR (which as my verbose comment noted: #52 (comment)) this is the variable which appeared to trigger udunits.. Want PR too? |
path above is dead. Which version has them? |
really need to learn to read it does say https:// .... |
that's the reason why the path wasn't written complete above.. so that google scours don't see this.. |
ok i'm almsot setup... but i do need 12 months of data your seem to have 1 only |
if you want a full suite take a peek at /export/durack1/140701_metrics/test and you should have all the variables I've been testing.. |
no worries got a working test with existing datasets and cdscan |
GFDL tos
The text was updated successfully, but these errors were encountered: