Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test suite needsdata to test udunits pkg #52

Closed
doutriaux1 opened this issue Aug 13, 2014 · 22 comments
Closed

test suite needsdata to test udunits pkg #52

doutriaux1 opened this issue Aug 13, 2014 · 22 comments
Assignees

Comments

@doutriaux1
Copy link
Contributor

GFDL tos

@durack1
Copy link
Collaborator

durack1 commented Aug 13, 2014

How do 66Kb and 204Kb files grab you? I can provide tos and pr (pr was the variable that appeared to need the udunits call).

The tos file (GFDL) has units of "degC" and the obs (NOAA-OISST-v2) has units of "K".
The pr file (GFDL) has units of "kg/m2/s" and the obs (GPCP) has units of "kg m-2 s-1"

@doutriaux1
Copy link
Contributor Author

sounds perfectly reasonable

@durack1
Copy link
Collaborator

durack1 commented Aug 13, 2014

Oh and the files have absolutely no history or metadata.. Did you want me to update these with some info as to where they've been obtained from, when, who etc?

@durack1
Copy link
Collaborator

durack1 commented Sep 11, 2014

@doutriaux1 let me know if you need anything more else from me here - it would be a good idea to add another test with the issue described in #68 - this issue should be magically dealt with by the software, rather than the issue we're hitting.. And possibly throwing an error statement to let the user know they their data has problems (if that is the cause)

@durack1 durack1 assigned doutriaux1 and unassigned durack1 Sep 17, 2014
@durack1
Copy link
Collaborator

durack1 commented Oct 21, 2014

@doutriaux1 what do you need data-wise for this?

There are some GFDL-ESM2G files hanging off: oceanonly.llnl.gov slash durack1/dump/140808_metrics

@durack1
Copy link
Collaborator

durack1 commented Oct 31, 2014

@doutriaux1 what else do you need for this, is this closed via #145?

@durack1 durack1 added this to the 1.0 - initial release milestone Oct 31, 2014
@doutriaux1
Copy link
Contributor Author

no we do not test for wrong/different units in this case.
I need to basically add 2 test case one for this and one for tas as @gleckler1 requested.

@durack1
Copy link
Collaborator

durack1 commented Oct 31, 2014

@doutriaux1 both TAS and TOS fields with the GFDL units (degrees_C) are findable at the URL (broken) above, and repeated here: oceanonly.llnl.gov slash durack1/dump/140808_metrics

@durack1
Copy link
Collaborator

durack1 commented Nov 14, 2014

@doutriaux1 this is 1 of 4 open issues which are associated with the 1.0 milestone.. Any work required on this or is it closeable?

@doutriaux1
Copy link
Contributor Author

let me see if I could reuse some of the example data we have via a cdscan and alter units even though it would lead to wrong result, we could check that we indeed get the wrong results, hence udunits worked

@durack1
Copy link
Collaborator

durack1 commented Nov 14, 2014

@doutriaux1 I don't think you need too.. The GFDL-ESM2G files that are findable at the links above should trigger UDUNITS..

@doutriaux1
Copy link
Contributor Author

how big are they. i'm trying to keep the repo small

@durack1
Copy link
Collaborator

durack1 commented Nov 14, 2014

66KB and 204KB as it says in #52 (comment)

@doutriaux1
Copy link
Contributor Author

I should learn to read....

@durack1
Copy link
Collaborator

durack1 commented Nov 14, 2014

I do try to be overly verbose in my comments.. You should know this by now..

@durack1
Copy link
Collaborator

durack1 commented Nov 14, 2014

though I've just noted that I gave you TAS and TOS, and not PR (which as my verbose comment noted: #52 (comment)) this is the variable which appeared to trigger udunits.. Want PR too?

@doutriaux1
Copy link
Contributor Author

path above is dead. Which version has them?

@doutriaux1
Copy link
Contributor Author

really need to learn to read it does say https:// ....

@durack1
Copy link
Collaborator

durack1 commented Nov 14, 2014

that's the reason why the path wasn't written complete above.. so that google scours don't see this..

@doutriaux1
Copy link
Contributor Author

ok i'm almsot setup... but i do need 12 months of data your seem to have 1 only

@durack1
Copy link
Collaborator

durack1 commented Nov 14, 2014

if you want a full suite take a peek at /export/durack1/140701_metrics/test and you should have all the variables I've been testing..

@doutriaux1
Copy link
Contributor Author

no worries got a working test with existing datasets and cdscan

durack1 added a commit that referenced this issue Nov 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants