Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Units for Derived Data #96

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Units for Derived Data #96

merged 1 commit into from
Mar 25, 2022

Conversation

Tomiiwa
Copy link
Contributor

@Tomiiwa Tomiiwa commented Mar 25, 2022

Fixes #5

@Milind220
Copy link
Collaborator

@Tomiiwa I'm going to review your code now, but two things to keep in mind for the future:

  1. Make your git commit messages as per the guidelines in the CONTRIBUTING file. This commit for example should've had the prefix [docs]

  2. The CONTRIBUTING file also states in a couple of places that PR's should only be targeted at the dev branch, yet yours is targeting the main branch. I'll change this manually for now, but make sure to get this right next time.

Milind220
Milind220 previously approved these changes Mar 25, 2022
View reviewed changes
@Milind220 Milind220 changed the base branch from main to dev March 25, 2022 14:13
@Milind220 Milind220 dismissed their stale review March 25, 2022 14:13

The base branch was changed.

@Milind220 Milind220 merged commit e9cd945 into Ozon3Org:dev Mar 25, 2022
@Tomiiwa
Copy link
Contributor Author

Tomiiwa commented Mar 25, 2022

apologies, will do that next time

@lahdjirayhan
Copy link
Contributor

For our future reference, can you provide sources of where is it mentioned that these are the measurement units? @Tomiiwa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milind220 Milind220 Milind220 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Tomiiwa @Milind220 @lahdjirayhan