Some changes to make mypy and flake8 in pre-commit happy #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to get rid of errors/warnings like 'library stubs not installed'
Note: this is supposed to be configurable via max-doc-length argument, but for some reason it won't work in my device
|
@lahdjirayhan Great! I have actually been getting same errors from mypy hopefully this keeps it happy for now 😉 |
Samxx97
previously approved these changes
Mar 23, 2022
Samxx97
approved these changes
Mar 23, 2022
|
Sorry I forget (again) to change the base branch. @Sam-damn Yeah, I hope there's no more issue about pre-commit. Frankly this is my first time using pre-commit. I'm really uncomfortable to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to make some changes in ozone.py to experiment, but pre-commit won't let me commit. So I propose this PR based on what I had to do to make pre-commit hooks all happy.
Note: for the reference on why I cut down the docstrings the way I did, see this question and answer: https://stackoverflow.com/questions/58930609/how-to-format-long-lines-of-argument-description-in-google-docstring-style