Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add semantic versioning and branching model sections #73

Merged
merged 3 commits into from
Mar 19, 2022

Conversation

kristinamancini
Copy link
Contributor

In the contributing file, I added 'Semantic Versioning System' and 'Github Branching Model' sections and short descriptions at the bottom of the file. I also added those two sections in the table of contents.

Copy link
Contributor

@Samxx97 Samxx97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kristinamancini Great work! i really love the short descriptions u provided and thank you for adding them into the the table of contents :)
i would like to request a small little change however, the links that are referred to should ideally be links to our discussions, since in the discussions we offer a little bit extra information. here are the links if u can add them in place of the ones u already have that would be great!

GitHub Branching Model url: #24
Semantic Versioning System url: #26

Additionally i think it would be better if the Semantic Versioning System section is moved to the bottom of the README.md right below the 'Contributing and submitting Pull requests' section and right above the 'World Air Quality Index and EPA attribution' section, instead of the contributing.md, and sorry for the mixup!

@kristinamancini
Copy link
Contributor Author

Got it, I believe I fixed it.

@Samxx97
Copy link
Contributor

Samxx97 commented Mar 19, 2022

Thank you very much @kristinamancini :)

@Samxx97 Samxx97 merged commit 9c40970 into Ozon3Org:dev Mar 19, 2022
@Milind220
Copy link
Collaborator

@kristinamancini Feel free to take a look at the other issues we have open, got some interesting ones there. We'd love to guide you through the process of making code contributions to Ozone!

@kristinamancini
Copy link
Contributor Author

I'll check out the other issues, thank you for allowing me to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a link to the versioning model in the README and the GitHub branching model in the CONTRIBUTING file
3 participants