Improve error messages #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make KeyError caught only when it's about missing air quality parameter, and not something else.
instead of rewriting most of the mostly the same logic again.
|
Great Job! i will review and test the code right now |
Samxx97
suggested changes
Mar 16, 2022
|
The rest of the code works flawlessly! Good job 💯 |
Co-authored-by: Sameh <[email protected]>
|
@Sam-damn Are there any other changes that you've requested, or was that one all? If that was it, then go ahead and merge this in :) |
Samxx97
approved these changes
Mar 17, 2022
|
All merged in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #66. Also attempts to improve most of the methods' exceptions.