Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pm25 label #139

Merged
merged 11 commits into from
May 3, 2022
Merged

Fix pm25 label #139

merged 11 commits into from
May 3, 2022

Conversation

Milind220
Copy link
Collaborator

This pull request:

  • Changes pm25 column labels from pm25 to pm2.5 across all of Ozone
  • Changes the custom param input from pm25 to pm2.5
  • Edits the tests for all of the above

Please let me know if I've missed anything

@Milind220 Milind220 linked an issue May 3, 2022 that may be closed by this pull request
The label of one column of the returned dataframe for all methods should be pm2.5, not pm25 #115
Closed
@Milind220
Copy link
Collaborator Author

Seems fine, merging in

@Milind220 Milind220 merged commit 638d177 into dev May 3, 2022
@Milind220 Milind220 deleted the fix-pm25-label branch May 3, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
breaking changes for version 2.0
Development

Successfully merging this pull request may close these issues.

The label of one column of the returned dataframe for all methods should be pm2.5, not pm25
1 participant
@Milind220