Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve file saving and its corresponding tests #133

Merged
merged 7 commits into from
Apr 25, 2022

Conversation

lahdjirayhan
Copy link
Contributor

No description provided.

to make it selectable via 'pytest -k output_data_format'
Note to self: 'pytest --disable-recording' will perform tests **without** VCR functionality,
so you can run it to see if the tests pass and it's the time to re-record the cassettes to
match up with the now-successful tests.
@@ -91,7 +91,8 @@ def __init__(

if self.file_name == "air_quality":
warnings.warn(
"You have not specified a custom save file name. Existing files with the same name may be overwritten!"
"You have not specified a custom save file name. "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh yes the cause of that annoying linter check fail

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black is not able to fix that for us, apparently.

@Milind220 Milind220 merged commit 538a0ba into Ozon3Org:dev Apr 25, 2022
@lahdjirayhan lahdjirayhan deleted the improve-filesave branch April 25, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants