Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests suite #120

Merged
merged 18 commits into from
Apr 22, 2022
Merged

Add tests suite #120

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
19520f3
test: Add test dependencies
lahdjirayhan Apr 20, 2022
e104d5d
test: Add initial setup for test files
lahdjirayhan Apr 20, 2022
7ba5a2f
test: Add tests for get_city_air
lahdjirayhan Apr 20, 2022
421eb16
test: Add tests for get_city_forecast
lahdjirayhan Apr 20, 2022
8c9b01f
test: Add tests for get_city_station_options
lahdjirayhan Apr 20, 2022
489abf1
test: Add tests for get_coordinate_air.py
lahdjirayhan Apr 20, 2022
472f33d
test: Add tests for get_historical_data
lahdjirayhan Apr 20, 2022
e94e41a
Save VCR cassettes into source control
lahdjirayhan Apr 21, 2022
d9be5d0
test: Add tests for get_multiple_city_air
lahdjirayhan Apr 22, 2022
3098ee1
test: Add tests for get_multiple_coordinate_air
lahdjirayhan Apr 22, 2022
7690a7e
test: Add tests for get_range_coordinates_air
lahdjirayhan Apr 22, 2022
29995e5
test: Add tests for get_specific_parameter
lahdjirayhan Apr 22, 2022
d46809c
test: Ensure no output folder is present at beginning of each test
lahdjirayhan Apr 22, 2022
19e151c
test: Move definition of DEFAULT_OUTPUT_FOLDER down
lahdjirayhan Apr 22, 2022
b66277f
test: Save more VCR cassettes into source control
lahdjirayhan Apr 22, 2022
6c88e35
test: Update tests to better reflect real conditions
lahdjirayhan Apr 22, 2022
4f5e2ca
test: Fix typo
lahdjirayhan Apr 22, 2022
c303611
docs: Add writeup for test instructions etc
lahdjirayhan Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: Update tests to better reflect real conditions
  • Loading branch information
@lahdjirayhan
lahdjirayhan committed Apr 22, 2022
commit 6c88e355dcc3e2374229a7381edea99d2bfed664
8 changes: 4 additions & 4 deletions tests/test_get_coordinate_air.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def test_column_expected_contents():

# London's coordinates
assert result.at[0, "latitude"] == pytest.approx(51.507351)
assert result.at[0, "longitude"] == pytest.approx(-0.127759)
assert result.at[0, "longitude"] == pytest.approx(-0.1277583)


@pytest.mark.vcr
Expand Down Expand Up @@ -85,9 +85,6 @@ def test_bad_coordinates():
with pytest.raises(Exception, match="Invalid geo position"):
api.get_coordinate_air(None, None)

with pytest.raises(Exception, match="Invalid geo position"):
api.get_coordinate_air(numpy.nan, numpy.nan)

# Giving coordinates as string of numerics is fine,
# even though it's not in accordance with Ozone's method definition.
api.get_coordinate_air("51.51", "-0.13")
Expand All @@ -96,6 +93,9 @@ def test_bad_coordinates():
api.get_coordinate_air(5000, 5000)
api.get_coordinate_air(-5000, -5000)

# Giving nan coordinates is also fine
api.get_coordinate_air(numpy.nan, numpy.nan)


@pytest.mark.vcr
def test_bad_data_format():
Expand Down