Add workflow to lint on Github #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahdjirayhan
force-pushed
the
add-workflows
branch
from
c1c7927
to
6fe5c75
Compare
lahdjirayhan
changed the title
lahdjirayhan
force-pushed
the
add-workflows
branch
from
7425d02
to
85a15d6
Compare
|
@lahdjirayhan This is great! We definitely could use this. This basically checks the code in PRs to make sure it follows our formatting rules right? |
Milind220
approved these changes
Apr 11, 2022
|
@Milind220 Yes. It will check every PR using flake8, black, and mypy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's good that we encourage contributors to use these linting and styling tools in
pre-commit, it doesn't hurt to also add these linters in Github actions.