Add/reimplement capability to get historical air quality data #104
Conversation
to simplify reading and understanding because it's not really necessary to put it in a separate subfolder
I forgot to remove it when writing and it escaped my subsequent reads
which is better than what I previously use but forgot to include in dependencies i.e. sseclient
When this happens, server does not return event stream. Thus, code will check first if server returns event stream or not.
The previous implementation fails when searching for the term 'ukraine', because one of the results don't have 'u' member
|
@lahdjirayhan Hey! Firstly, absolutely legendary work with this feature.The amount of effort you put in is so amazing - the feature's really well made. My review will follow this comment |
There was a problem hiding this comment.
Tried it out with 10 different cities, and it works great.
- I love that it lets users know what station it's getting data from so they can choose better
- Works really fast, far faster than the selenium solution that we were going for earlier, so definitely a much better implementation
I've added a few review comments, after which I think it's good to go!
|
@lahdjirayhan Thank you so much for working on this with such dedication. Your contributions to Ozone have been extremely valuable and high quality. |
by removing decorator and adding docstring
|
@Milind220 Thank you, too, for having me as a contributor to this project! A wonderful opportunity. Hope Ozone can be useful to a lot of people! |
This PR enables Ozone to get historical air quality data through the means of (as noted in #58):
js2py.User can provide either city name or city ID. If only city name is provided, the first search result's city ID will be used, and a warning will be displayed telling the user what city ID and station name was called.
I'm explicitly welcoming reviews and suggestions for improvement. After all, I may have accidentally overlooked some stuffs that are not immediately obvious to me at the time of writing the code.