Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - InteractionProfilerGrain #345

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Prev Previous commit
Next Next commit
Revert "InteractionProfilerGrain"
This reverts commit c321edf.
  • Loading branch information
KSemenenko committed Oct 23, 2022
commit 11967cbdf403f975b0eeef906fe6921c4b3b3886
5 changes: 0 additions & 5 deletions OrleansDashboard.Core/IDashboardGrain.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ public interface IDashboardGrain : IGrainWithIntegerKey

[OneWay]
Task SubmitTracing(string siloAddress, Immutable<SiloGrainTraceEntry[]> grainCallTime);

[OneWay]
Task SubmitGrainInteraction(string interactionsGraph);

Task<Immutable<DashboardCounters>> GetCounters();

Expand All @@ -27,7 +24,5 @@ public interface IDashboardGrain : IGrainWithIntegerKey
Task<Immutable<Dictionary<string, GrainTraceEntry>>> GetSiloTracing(string address);

Task<Immutable<Dictionary<string, GrainMethodAggregate[]>>> TopGrainMethods();

Task<string> GetInteractionsGraph();
}
}
15 changes: 0 additions & 15 deletions OrleansDashboard.Core/Metrics/IGrainInteractionProfiler.cs

This file was deleted.

1 change: 0 additions & 1 deletion OrleansDashboard.Core/Model/DashboardCounters.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,5 @@ public DashboardCounters()
public SimpleGrainStatisticCounter[] SimpleGrainStats { get; set; }
public int TotalActivationCount { get; set; }
public ImmutableQueue<int> TotalActivationCountHistory { get; set; }
public string InteractionsGraph { get; set; }
}
}
15 changes: 0 additions & 15 deletions OrleansDashboard.Core/Model/GrainInteractionInfoEntry.cs

This file was deleted.

101 changes: 0 additions & 101 deletions OrleansDashboard/Implementation/GrainInteractionFilter.cs

This file was deleted.

15 changes: 2 additions & 13 deletions OrleansDashboard/Implementation/Grains/DashboardGrain.cs
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public override Task OnActivateAsync()

return base.OnActivateAsync();
}

public async Task<Immutable<DashboardCounters>> GetCounters()
{
await EnsureCountersAreUpToDate();
Expand Down Expand Up @@ -156,12 +156,7 @@ public async Task<Immutable<Dictionary<string, GrainMethodAggregate[]>>> TopGrai
{ "errors", values.Where(x => x.ExceptionCount > 0 && x.Count > 0).OrderByDescending(x => x.ExceptionCount / x.Count).Take(numberOfResultsToReturn).ToArray() },
}.AsImmutable();
}

public Task<string> GetInteractionsGraph()
{
return Task.FromResult(counters.InteractionsGraph);
}


public Task Init()
{
// just used to activate the grain
Expand All @@ -174,11 +169,5 @@ public Task SubmitTracing(string siloAddress, Immutable<SiloGrainTraceEntry[]> g

return Task.CompletedTask;
}

public Task SubmitGrainInteraction(string interactionsGraph)
{
counters.InteractionsGraph = interactionsGraph;
return Task.CompletedTask;
}
}
}
103 changes: 0 additions & 103 deletions OrleansDashboard/Implementation/Grains/InteractionProfilerGrain.cs

This file was deleted.

2 changes: 0 additions & 2 deletions OrleansDashboard/ServiceCollectionExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ public static ISiloHostBuilder UseDashboard(this ISiloHostBuilder builder,
{
builder.ConfigureApplicationParts(parts => parts.AddDashboardParts());
builder.ConfigureServices(services => services.AddDashboard(configurator));
builder.AddIncomingGrainCallFilter<GrainInteractionFilter>();
builder.AddOutgoingGrainCallFilter<GrainInteractionFilter>();
builder.AddStartupTask<Dashboard>();

return builder;
Expand Down