Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move (de-)serialization from Newtonsoft.JSON to System.Json.Text #64

Merged
merged 5 commits into from
Feb 17, 2023
Merged

Move (de-)serialization from Newtonsoft.JSON to System.Json.Text #64

merged 5 commits into from
Feb 17, 2023

Conversation

vader1986
Copy link
Contributor

#63

@vader1986 vader1986 closed this Feb 15, 2023
@vader1986 vader1986 reopened this Feb 15, 2023
@vader1986
Copy link
Contributor Author

I can't really get the unit tests running on my machine (yet). However, the sample services are running - is there anything in particular to look for?

@vader1986
Copy link
Contributor Author

Unit tests are running through fine now (just had my cluster running in a different namespace & selected wrong k8s config)

Move (de-)serialization from Newtonsoft.JSON to System.Json.Text
b92614b 
Updated de-serialization
Fixed unit test project
Fixed broken dockerfiles for testing
@SamEmber SamEmber mentioned this pull request Feb 16, 2023
Closed
@SamEmber
Copy link

Thanks @vader1986, @galvesribeiro would you be able to take a look when possible please? Thanks!

@galvesribeiro
Copy link
Member

galvesribeiro commented Feb 17, 2023 •
edited
Loading

Hey folks. I tried to run the test here but it doesn't work. In the past it used to work just fine. @vader1986 what have you did to make it work? I keep getting 404 on all requests. I wonder if the APIs changed.

galvesribeiro
galvesribeiro approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@galvesribeiro galvesribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@galvesribeiro
Copy link
Member

I've fixed the tests. Thank you!

@galvesribeiro galvesribeiro merged commit ce56475 into OrleansContrib:master Feb 17, 2023
@vader1986 vader1986 deleted the system-json-text branch February 18, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galvesribeiro galvesribeiro galvesribeiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vader1986 @SamEmber @galvesribeiro