Fixes HTTPS Error On Logout #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue Orangescrum#111 (https://github.com/Orangescrum/orangescrum/issues/111). Should work for both HTTP and HTTPS.
|
This error of using HTTP_ROOT instead of HTTPS_HOME occurs throughout this file (and throughout the entire web app, actually). There are 81 replacements needed in this file alone. Simple find/replace of HTTP_ROOT to HTTPS_HOME basically works. |
|
There's no need to go replacing HTTP_ROOT throughout the whole application. My company has been using Orange Scrum for the past 11 months with HTTPS. We just changed the one reference to HTTP_HOME to HTTPS_HOME and everything works (we might have used https in the url for the HTTP_HOME constant, I can't remember at the moment.) No problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #111. Should work for both HTTP and HTTPS.