Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation #29

Merged
merged 6 commits into from
Sep 18, 2020
Merged

Validation #29

merged 6 commits into from
Sep 18, 2020

Conversation

frisbm
Copy link
Contributor

@frisbm frisbm commented Sep 8, 2020

FHIR Validation for DSTU3, R4, and R5

Related US/Task

Solves #17

Motivation and Context

Add the ability to validate the FHIR resources being added to the database to ensure they are meeting the FHIR standard, the validation code is generated running the bin/generate-validator.sh to use validation in cypher you can add config map when loading, it is documented in the updated readme

How Has This Been Tested

Wrote tests for all the supported versions and to check generated validation code

Types of changes

  • Refactoring / dependency upgrade / docs change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional requirement

@frisbm frisbm added enhancement New feature or request wip Work in Progress 1.0 release Slated for 1.0 release dependencies Pull requests that update a dependency file labels Sep 8, 2020
@frisbm frisbm added this to In progress in CyFHIR via automation Sep 8, 2020
@frisbm frisbm self-assigned this Sep 8, 2020
@frisbm frisbm linked an issue Sep 8, 2020 that may be closed by this pull request
@frisbm frisbm requested a review from DMadrid September 16, 2020 23:46
@DMadrid DMadrid removed the wip Work in Progress label Sep 18, 2020
Copy link
Contributor

@DMadrid DMadrid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CyFHIR automation moved this from In progress to Reviewer approved Sep 18, 2020
@frisbm frisbm merged commit 32778a2 into master Sep 18, 2020
CyFHIR automation moved this from Reviewer approved to Done Sep 18, 2020
@frisbm frisbm deleted the validation branch September 18, 2020 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 release Slated for 1.0 release dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
No open projects
CyFHIR
  
Done
Development

Successfully merging this pull request may close these issues.

FHIR Validation
2 participants