Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single resource #25

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Single resource #25

merged 2 commits into from
Aug 12, 2020

Conversation

frisbm
Copy link
Contributor

@frisbm frisbm commented Aug 10, 2020

#Allow loading and formatting based on single Resources, not just FHIR Bundles.
Refactor code with this in mind, moving all base steps for entries in bundle to the resource class. Added tests as well.

Related US/Task

Closes #19

Motivation and Context

Required to have more versatility and remove useless FHIR Bundle wrapper for cases of 1 Resource

How Has This Been Tested

Through unit tests written by myself, in Neo4j desktop, and against my local docker environment with our typescript test harness

Types of changes

  • Refactoring / dependency upgrade / docs change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional requirement

Visual screenshots

N/A

@frisbm frisbm requested a review from DMadrid August 10, 2020 05:40
@frisbm frisbm self-assigned this Aug 10, 2020
@frisbm frisbm added 1.0 release Slated for 1.0 release enhancement New feature or request labels Aug 10, 2020
@frisbm frisbm added this to In progress in CyFHIR via automation Aug 10, 2020
@frisbm frisbm linked an issue Aug 10, 2020 that may be closed by this pull request
CyFHIR automation moved this from In progress to Reviewer approved Aug 12, 2020
@frisbm frisbm merged commit b6bdd75 into master Aug 12, 2020
CyFHIR automation moved this from Reviewer approved to Done Aug 12, 2020
@frisbm frisbm deleted the singleResource branch August 12, 2020 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 release Slated for 1.0 release enhancement New feature or request
Projects
No open projects
CyFHIR
  
Done
Development

Successfully merging this pull request may close these issues.

Singular Resource
2 participants