US18: Unit Tests #23
Merged
US18: Unit Tests #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frisbm
added
wip
DMadrid
reviewed
Aug 6, 2020
|
Tests passing locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding unit tests to the CyFHIR Java project to better be able to automate our testing and improve the quality of our code
IMPORTANT
These tests use testcontainers and therefore need to be able to spinup docker containers locally to run. Please make sure you have docker running before running these tests
Tests run with
make testin the root of the projectRelated US/Task
Resolves #18
Motivation and Context
We needed an actual testing harness to be able to thoroughly verify existing code/algorithms but also for future development
How Has This Been Tested
Testes against our original 'tests' (the swagger docs)
Types of changes
Visual screenshots
N/A