Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 4.1 #22

Merged
merged 3 commits into from
Jul 12, 2020
Merged

Update 4.1 #22

merged 3 commits into from
Jul 12, 2020

Conversation

frisbm
Copy link
Contributor

@frisbm frisbm commented Jul 10, 2020

Update Codebase for Neo4j v4.1.x and other updates

Related US/Task

N/A

Motivation and Context

Have an updated codebase before starting more code, also minimize package and generally cleaned up dependencies

How Has This Been Tested

Tested every bit of code affected by updated dependencies

Types of changes

  • Refactoring / dependency upgrade / docs change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional requirement

Visual screenshots

N/A

@frisbm frisbm self-assigned this Jul 10, 2020
@frisbm frisbm added the non-functional Does not directly impact functionality of plugin label Jul 10, 2020
@frisbm frisbm added this to In progress in CyFHIR via automation Jul 10, 2020
@frisbm
Copy link
Contributor Author

frisbm commented Jul 10, 2020

Pull the branch, be sure to run npm ci in the express folder before running and test the dockerfile build with make backend as well as the individual jar if possible

CyFHIR automation moved this from In progress to Reviewer approved Jul 12, 2020
@frisbm frisbm merged commit 7fc0a99 into master Jul 12, 2020
CyFHIR automation moved this from Reviewer approved to Done Jul 12, 2020
@frisbm frisbm deleted the update-4.1 branch July 12, 2020 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMadrid DMadrid DMadrid approved these changes

@lironbenjamin lironbenjamin Awaiting requested review from lironbenjamin

Assignees

@frisbm frisbm

Labels
non-functional Does not directly impact functionality of plugin
Projects
No open projects
CyFHIR
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frisbm @DMadrid