Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property bug #16

Merged
merged 2 commits into from
Jun 13, 2020
Merged

Property bug #16

merged 2 commits into from
Jun 13, 2020

Conversation

frisbm
Copy link
Contributor

@frisbm frisbm commented Jun 12, 2020

Multiple Bug Fixes

  • Neo4j driver had unexpected data resolution format for integers because Neo4j uses 64-bit signed Integers and Node.js does not. Resolved with appropriate flag in instantiation of Neo4j driver in the express server.
  • Swagger Doc example bundle contained resources that were more than one degree away from example patient which made testing for accuracy of bundles before and after entering the Database difficult. Resolved by removing those resources.
  • Bug in cyfhir.bundle.build() where Arrays of Numerics were being left as Arrays of strings and was not up to FHIR standard

Related US/Task

N/A

Motivation and Context

As of now are completely within FHIR standards, we can recreate the FHIR resources identically to when they came in.

How Has This Been Tested

Comparing many bundles to themselves over and over again with different filtering, still not unit tests

Types of changes

  • Refactoring / dependency upgrade / docs change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional requirement

Visual screenshots

Deep Sort and Deep Comparison of the original FHIR bundle and the bundle from the cyfhir response
image

@frisbm frisbm self-assigned this Jun 12, 2020
@frisbm frisbm added the bug Something isn't working label Jun 12, 2020
@frisbm frisbm added this to In progress in CyFHIR via automation Jun 12, 2020
CyFHIR automation moved this from In progress to Reviewer approved Jun 12, 2020
Copy link
Contributor

@tyleryam tyleryam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frisbm frisbm merged commit d0c210f into master Jun 13, 2020
CyFHIR automation moved this from Reviewer approved to Done Jun 13, 2020
@frisbm frisbm deleted the property-bug branch June 13, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
CyFHIR
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants