Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure Code #13

Merged
merged 2 commits into from
May 27, 2020
Merged

Restructure Code #13

merged 2 commits into from
May 27, 2020

Conversation

frisbm
Copy link
Contributor

@frisbm frisbm commented May 25, 2020

Description

Restructure Code to better keep organization for future additions to the codebase

Related US/Task

N/A

Motivation and Context

Having all of the code in one file was unsustainable

How Has This Been Tested

Compiled and build code to test functionality of procedures and functions and everything still works the same

Types of changes

  • Refactoring / dependency upgrade / docs change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional requirement

Visual screenshots

N/A

@frisbm frisbm added the enhancement New feature or request label May 25, 2020
@frisbm frisbm self-assigned this May 25, 2020
@frisbm frisbm added this to Review in progress in CyFHIR May 26, 2020
CyFHIR automation moved this from Review in progress to Reviewer approved May 27, 2020
lironbenjamin
lironbenjamin approved these changes May 27, 2020
View reviewed changes
Copy link

@lironbenjamin lironbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner and easier to follow. LGTM.

@frisbm frisbm merged commit 2e0bdd1 into master May 27, 2020
CyFHIR automation moved this from Reviewer approved to Done May 27, 2020
@frisbm frisbm deleted the structure branch May 27, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyleryam tyleryam tyleryam left review comments

@DMadrid DMadrid DMadrid approved these changes

@lironbenjamin lironbenjamin lironbenjamin approved these changes

Assignees

@frisbm frisbm

Labels
enhancement New feature or request
Projects
No open projects
CyFHIR
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@frisbm @DMadrid @lironbenjamin @tyleryam