Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Code Preparation #1

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Release: Code Preparation #1

merged 2 commits into from
Apr 29, 2020

Conversation

frisbm
Copy link
Contributor

@frisbm frisbm commented Apr 29, 2020

Description

Fixed new bug in Cypher for /LoadBundle and /BuildBundle/:_id where in upgrading Neo4J to 4.0.X Optional Match did not work as expected, should be resolved, also added new api call /compareJSON that sorts and compares objects to assert functions are isomorphic.

Related US/Task

N/A

Motivation and Context

Bug solve and for debugging purposes

How Has This Been Tested

Created the function to test it, plan on working on more tests in the future

Types of changes

  • Refactoring / dependency upgrade / docs change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional requirement

Visual screenshots

N/A

@frisbm frisbm added bug Something isn't working enhancement New feature or request labels Apr 29, 2020
@frisbm frisbm requested a review from DMadrid April 29, 2020 13:35
@frisbm frisbm self-assigned this Apr 29, 2020
@frisbm frisbm requested review from lironbenjamin and removed request for DMadrid April 29, 2020 13:36
Copy link

@lironbenjamin lironbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- actually like the removal of the OPTIONAL MATCH, I think the use of two separate MATCH statements is easier to follow and makes more sense to me

@frisbm frisbm merged commit 75d9c16 into master Apr 29, 2020
@frisbm frisbm deleted the release-prep branch April 30, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants