refactor(protocol-designer): change selected path icon border #9663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #9663 +/- ##
=======================================
Coverage 75.34% 75.34%
=======================================
Files 1927 1927
Lines 50718 50718
Branches 4844 4844
=======================================
Hits 38214 38214
Misses 11590 11590
Partials 914 914
Flags with carried forward coverage won't be shown. Click here to find out more. |
sakibh
approved these changes
Mar 11, 2022
| } | ||
|
|
||
| .path_option.selected { | ||
| background-color: var(--c-light-gray); | ||
| border-radius: 2px; | ||
| border: 1.5px solid #000; |
There was a problem hiding this comment.
For this you can do var(--c-black). The colors.css is helpful for this.
| cursor: pointer; | ||
| border-radius: 2px; | ||
| border: 1px solid #c4c4c4; |
There was a problem hiding this comment.
Is #c4c4c4 commonly used now in the new Figma designs for PD? If so might be worth adding to colors.css.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9658
Overview
This is a quick change to update the path border in PD under transfer step to match the new designs
Changelog
path_optionin CSS style sheetpath_option.selectedin style sheetReview requests
Risk assessment
low