feat(app): add selectors to Module Cards #9636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #9636 +/- ##
=======================================
Coverage 75.57% 75.57%
=======================================
Files 1927 1927
Lines 51281 51281
Branches 4919 4919
=======================================
Hits 38758 38758
Misses 11593 11593
Partials 930 930
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sakibh
approved these changes
Mar 7, 2022
| @@ -30,6 +30,7 @@ export const StatusLabel = (props: StatusLabelProps): JSX.Element | null => { | |||
| alignItems={ALIGN_CENTER} | |||
| marginTop={SPACING_1} | |||
| marginBottom={SPACING_1} | |||
| data-testid={`status_label+${status}`} | |||
sakibh
reviewed
Mar 7, 2022
| <Flex | ||
| flexDirection={DIRECTION_COLUMN} | ||
| marginRight={SPACING.spacing6} | ||
| data-testid={`heater_shaker_module_data_temp`} |
There was a problem hiding this comment.
nit: also I this should probably be single quotes since back ticks are generally used for string interpolation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9359
Overview
This PR goes back and adds selectors to module card work since it was previously skipped since multiple people were working on different parts of it simultaneously.
Changelog
moduleCard, each of the module data components, and thestatusLabelReview requests
make sure adding selectors didn't do anything weird
Risk assessment
low