Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): make story for MenuItem, Slideout, and OverflowBtn #9455

Merged
merged 5 commits into from
Feb 16, 2022

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Feb 14, 2022

closes #9449

Overview

This PR makes a story for the shared components: MenuItem, Slideout, and OverflowBtn and MenuList, so you can see the different states they have and what the component looks like. - also renames OverflowMenuBtn to MenuItem and OverflowMenu to MenuList

They are all under App -> Atoms

Screen Shot 2022-02-16 at 10 32 55 AM

Changelog

  • created 4 stories

Slideout:

Screen Shot 2022-02-14 at 12 54 21 PM

MenuItem: (need to interact with it to see states)
Screen Shot 2022-02-14 at 12 54 50 PM

OverflowBtn: (need to interact with it to see states)
Screen Shot 2022-02-14 at 12 55 15 PM

MenuList: (need to interact with it to see states)
Screen Shot 2022-02-16 at 1 12 58 PM

Review requests

  • go to StoryBook or if that's not built yet, in terminal, type in make -C components dev
  • navigate on the left menu to App -> Atoms. There should be 3 folders each with 1 item in them, that is where each of the stories live
  • review OverflowBtn - you should see the different states when you interact with it (hover, focus, etc)
  • review MenuItem - you should also see different states when you interact with it
  • review Slideout - you have to toggle the isExpanded to true, then you will see the Slideout with example title, and example body (example body even includes a button)
  • review MenuList

Risk assessment

low, behind ff

@jerader jerader requested a review from a team as a code owner February 14, 2022 17:52
@jerader jerader requested review from mcous, sakibh, shlokamin and a team and removed request for a team and mcous February 14, 2022 17:52
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #9455 (9e5b5cb) into edge (68eda33) will decrease coverage by 0.02%.
The diff coverage is 17.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #9455      +/-   ##
==========================================
- Coverage   75.11%   75.09%   -0.03%     
==========================================
  Files        1878     1882       +4     
  Lines       49746    49766      +20     
  Branches     4836     4836              
==========================================
+ Hits        37369    37371       +2     
- Misses      11476    11494      +18     
  Partials      901      901              
Flag Coverage Δ
app 73.25% <17.39%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/src/atoms/MenuList/MenuItem.stories.tsx 0.00% <0.00%> (ø)
app/src/atoms/MenuList/MenuList.stories.tsx 0.00% <0.00%> (ø)
app/src/atoms/MenuList/OverflowBtn.stories.tsx 0.00% <0.00%> (ø)
app/src/atoms/MenuList/OverflowBtn.tsx 100.00% <ø> (ø)
app/src/atoms/Slideout/Slideout.stories.tsx 0.00% <0.00%> (ø)
app/src/organisms/Devices/ModuleCard/index.tsx 95.23% <ø> (ø)
app/src/atoms/MenuList/MenuItem.tsx 100.00% <100.00%> (ø)
app/src/atoms/MenuList/index.tsx 100.00% <100.00%> (ø)
...rganisms/Devices/ModuleCard/ModuleOverflowMenu.tsx 80.00% <100.00%> (+0.83%) ⬆️
...are/hardware_control/motion_planning/move_utils.py 91.52% <0.00%> (-0.57%) ⬇️
... and 1 more

Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅 📖 Looks great! Thank you for this!

@jerader jerader changed the title feat(app): make story for OverflowMenuBtn, Slideout, and OverflowBtn feat(app): make story for MenuItem, Slideout, and OverflowBtn Feb 16, 2022
Copy link
Contributor

@sakibh sakibh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@jerader jerader merged commit b10dcb3 into edge Feb 16, 2022
@jerader jerader deleted the app_storybook-overflow-comps branch February 16, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OverflowBtn, OverflowMenuBtn and Slideout to Storybook
3 participants